Skip to content

FORMS-18730: Text content lacks 4.5:1 contrast ratio @sunnym @vavarshn#38

Merged
CezarSTF merged 1 commit intomainfrom
ens83070/FORMS-18730
Jun 25, 2025
Merged

FORMS-18730: Text content lacks 4.5:1 contrast ratio @sunnym @vavarshn#38
CezarSTF merged 1 commit intomainfrom
ens83070/FORMS-18730

Conversation

@CezarSTF
Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CezarSTF CezarSTF requested review from akshayvas and amit-mnnit June 19, 2025 09:20
Copy link
Copy Markdown
Contributor

@akshayvas akshayvas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CezarSTF Approving. Though the difference in shade looks fine in code, Just check once if the transition between normal and hover state looks noticeable before merging.
cc: @vaibhav2601

@CezarSTF
Copy link
Copy Markdown
Collaborator Author

@akshayvas
image
image

@CezarSTF CezarSTF merged commit 5bf0e2f into main Jun 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants